Add option for debug output to default to silent #356
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padelsbach
reviewed
Jan 30, 2026
| /* Silent mode gate - when active, blocks all logging output regardless of | ||
| * loggingEnabled. Only deactivated when WOLFPROV_LOG_LEVEL or | ||
| * WOLFPROV_LOG_COMPONENTS environment variables are set at runtime. */ | ||
| static int silentModeActive = 1; |
Contributor
There was a problem hiding this comment.
Rather than adding yet another flag, can we just change the defaults for the existing flags? Eg:
#ifdef WOLFPROV_DEBUG_SILENT
static int providerLogLevel = 0;
static int providerLogComponents = 0;
#else
static int providerLogLevel = WP_LOG_LEVEL_ALL;
static int providerLogComponents = WP_LOG_COMP_ALL;
#endif
| char logMessage[WOLFPROV_MAX_LOG_WIDTH]; | ||
|
|
||
| /* Don't log if logging is disabled */ | ||
| if (!loggingEnabled) { |
Contributor
|
Why do we need a special build for this? Why can't they use the env vars? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the debug build is noisy with default logging options. This is not suitable for testing systems with many applications as the log pollution becomes a problem. Add option for debug output to default to silent, with option to enable level or component specific logging at runtime with environment variables.