Added Analysis info to tableau detector #4717
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| ignoreOpts := []cmp.Option{ | ||
| cmpopts.IgnoreFields(detectors.Result{}, "Raw", "RawV2", "verificationError", "ExtraData"), | ||
| cmpopts.IgnoreFields(detectors.Result{}, "Raw", "RawV2", "verificationError", "ExtraData", "AnalysisInfo"), |
There was a problem hiding this comment.
Test ignores AnalysisInfo field rendering expected values useless
Medium Severity
The test adds expected AnalysisInfo values (lines 72-76) but then adds AnalysisInfo to cmpopts.IgnoreFields (line 262), which means the comparison will never verify these values. The expected AnalysisInfo is effectively dead code that provides false confidence the feature is tested. Other integration tests like dockerhub_integration_test.go either test AnalysisInfo properly (without ignoring it) or don't include expected values at all.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
analysisInfoindetector.Resultstruct of tableau detector to support tableau analyzer.Checklist:
make test-community)?make lintthis requires golangci-lint)?