[INS-249] Updated Gitlab client from v0.129.0 to v1.12.0(latest) #4655
Conversation
|
Please do not merge this before this one: #4608 I want these changes to go to Enterprise first. |
kashifkhan0771
left a comment
kashifkhan0771
left a comment
There was a problem hiding this comment.
Need to resolve the conflicts.
Thank you for waiting. The PR is merged, you can resolve the conflicts and we can review this PR. |
Removed unused 'time' import from gitlab.go
camgunz
left a comment
camgunz
left a comment
There was a problem hiding this comment.
LG! Just want that line split up then merge away 👍🏻
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not create Gitlab OAUTH client for %q: %w", s.url, err) | ||
| return nil, fmt.Errorf("could not create Gitlab TOKEN client for %q: %w", s.url, err) |
There was a problem hiding this comment.
Incorrect error message for OAUTH authentication case
Low Severity
The error message in the case "OAUTH": block incorrectly says "could not create Gitlab TOKEN client" instead of "could not create Gitlab OAUTH client". This mismatch between the authentication method being used and the error message could cause confusion when debugging authentication failures.
| return nil, fmt.Errorf("could not create Gitlab TOKEN client for %q: %w", s.url, err) | ||
| } | ||
| return apiClient, nil | ||
|
|
There was a problem hiding this comment.
Duplicated code between OAUTH and TOKEN cases
Low Severity
The case "OAUTH": block (lines 475-486) and case "TOKEN": block (lines 505-516) now have identical implementations after the library upgrade. Both create an oauth2.StaticTokenSource, call gitlab.NewAuthSourceClient with gitlab.OAuthTokenSource{TokenSource: ts}, and use the same options. This duplication increases maintenance burden since any fix or change would need to be applied in both places. These cases could be combined into case "OAUTH", "TOKEN": to eliminate the redundancy.
Additional Locations (1)
5 participants
Description:
This pull request introduces the following changes:
v0.129.0tov1.12.0in go.mod.filesystem_integration_test.goandgitlab_integration_test.godue to missing import ofdefaultspackage.gitlab_integration_test.goto make sure that the test passes.basic auth, scoped repotest to use creds of non-2fa account as gitlab no longer allows repo to be cloned with password of a 2fa enabled account.Checklist:
make test-community)?make lintthis requires golangci-lint)?