fix: use public methods instead of private attributes in tests #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimosky
reviewed
Jan 22, 2026
| # Method might not exist in simplified version | ||
| pass | ||
|
|
||
| def test_do_set_property_invalid(self): |
Member
There was a problem hiding this comment.
Any particular reason for deleting this test?
| tool_combo.set_label_text("Test Property") | ||
| self.assertEqual(tool_combo.get_label_text(), "Test Property") | ||
|
|
||
| def test_do_set_property_method(self): |
Part of sugarlabs#7 - Add get_item_count() to ComboBox for test access - Update test assertions to use existing public methods
vyagh
force-pushed
the
fix/tests-public-properties
branch
from
2e0a4eb to
e3e3d8a
Compare
Author
|
my bad, I overcomplicated it. Fixed it |
Member
|
Looks good so far, see making commits for future reference re commit messages. |
- Add get_model(), get_item_at(), has_text_renderer(), has_icon_renderer(), is_separator_at() to ComboBox - Update test assertions to use public API
vyagh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Summary
Tests were accessing private attributes directly. This PR adds public accessor methods so tests use proper public API.
Progress
Testing
All existing tests pass. No regressions.