fix: remove unsafe-eval from utils.js #5420
Open
+61
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
eval()fallback fromresolveObjectin utils.js to improve security and CSP compliance.Previously,
resolveObjectusedeval(path)because many classes (like Turtle, MusicBlocks, and the APIs) weren't exposed to the global window object, so standard property lookup failed.Changes:
resolveObjectnow strictly usespath.split('.').reduce(...)to find properties. Theevalfallback is gone.window.Turtle = Turtle) soresolveObjectcan find them.*BlocksAPIclasses.importController(unused dead code) and commented safeEval usage for clarity.Verification
npm testpassing (89/89 suites). Confirmed the hoisting fix works (window assignments are at the end of files).ReferenceErroror resolution failures in the console