refactor turtle access in EnsembleBlocks #5415
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Hi @7se7en72025, nice catch on the turtle indexing bug! 🚀 I noticed the checks are failing on the Lint step. This is likely because PR #5388 recently updated the project's formatting rules (Prettier v6). The CI is now enforcing the new style, which conflicts with the old formatting in this file. If you run |
|
Hi @Inuth0603, |
|
Ah, I see! This happens because your local Since PR #5388 merged recently, you need to refresh your environment to get the new Prettier v6 rules. Try this:
That should force the new formatting changes to appear! 🚀 |
|
sorry but i tried it, the result was same tho |
|
Hey @7se7en72025, this has happened to me as well. I have checked your ESLint Errors, and it seems like the error is because of 3 files you never touched. I suggest you run Prettier on them and commit. Try: |
Simplified turtle object access in the arg method by using the already found turtle instead of re-fetching it. Also reformatted assignment for singer.turtleTime for better readability. Refactor object keys and formatting in JS files Updated test and code files to use numeric keys instead of string keys for object properties where appropriate. Improved code formatting for better readability in turtle.js and script.js.
7se7en72025
force-pushed
the
fix/bezier-animation
branch
from
ed7cfa6 to
c7bd424
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
|
W @Inuth0603 @kartikktripathi |
|
No problem, cheers to open source! |
3 participants
When a user used the mouse notes played block to query a specific turtle (e.g., targeting "Mr. Mouse"), the code would incorrectly pass a Turtle object into activity.turtles.ithTurtle(), which expects an integer index. This was a failure and a crash (Error: Turtle [object Object] not found).