refactor: consolidate duplicate readAsDataURL logic in block.js #5414
+25
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Inuth0603
force-pushed
the
fix/duplicate-code
branch
from
8974633 to
07942ad
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Combine duplicate conditional branches where both 'media' and 'audiofile' cases called the same readAsDataURL method. Restore semicolon in utils.js for ESLint/prettier compliance. Format block.js with Prettier 2.0.5 to match CI.
Inuth0603
force-pushed
the
fix/duplicate-code
branch
from
07942ad to
ffea645
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
kartikktripathi
approved these changes
Jan 29, 2026
Contributor
kartikktripathi
left a comment
kartikktripathi
left a comment
There was a problem hiding this comment.
Hey, I reviewed your code, and everything seems perfectly fine, LGTM, Good Contribution!
Contributor
Author
Thanks for the review @kartikktripathi! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
js/block.jsto combine duplicatereadAsDataURLcalls into a single conditional branch (DRY).Formatting Note:
Since PR #5388 (update gulp-prettier to v6) was merged recently, this file required reformatting to pass the new CI/CD standards. The large diff reflects the auto-formatting updates enforced by Prettier 2.8.8.