Added visual highlight for selected language in dropdown #5411
+106
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
kh-ub-ayb
force-pushed
the
selected-language
branch
from
8136f5a to
273427e
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
kh-ub-ayb
force-pushed
the
selected-language
branch
from
273427e to
ae01b21
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@walterbender @omsuneri please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when clicking on the language select icon (
#languageSelectIcon) and opening the language dropdown, users cannot visually identify which language is currently selected. This PR adds a clear visual indicator to highlight the currently selected language.Changes Made
CSS (
css/themes.css).selected-languageclass with blue left border and subtle background highlightJavaScript (
js/toolbar.js)renderLanguageSelectIcon()to:en-US→enUS) for first-time usersBEFORE
AFTER
Testing
npm run lintRelated Issue
Fixes #5410