Add install button for PWA using deferredPrompt #5406
+43
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5405
This PR completes the existing PWA install flow by exposing a minimal
install UI when the browser fires the
beforeinstallpromptevent.Previously, the install prompt event was captured but never surfaced
to users. This change adds a small, non-intrusive install button that
appears only when installation is possible and triggers the prompt
via a user gesture, as required by browsers.
Changes:
beforeinstallpromptfiresdeferredPrompt.prompt()on user clickuserChoiceand clear state after useThis does not alter existing behavior and only makes the already
captured install capability usable.