Fix ReferenceErrors and Loading Order for Search & Tags #5400
+5,475
−4,970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
* feat: Upgrade Horizontal Scrolling to Omnidirectional Scrolling - Replaces 'Horizontal Scrolling' with 'Omnidirectional Scrolling' - Enables simultaneous X and Y scrolling (diagonal panning) when enabled in Advanced Mode - Restricts scrolling to Vertical-only in Beginner Mode or when disabled - Updates UI strings, tooltips, and Pie Menu labels to reflect the new functionality * style: Remove redundant JSDoc comment in activity.js * Linitng changes * Keeping the Horizontal name intact * Linting changes
…abs#5138) * Fix i18n: Add missing Telugu translation and localize confirm and cancel buttons * Add Telugu translation for 'Clear Workspace'
* Fix broken Music Blocks Guide link (404) * Format turtledefs.js with Prettier * Update guide link to Docs/guide after docs refactor * fixed(turtle) link: --------- Co-authored-by: Walter Bender <walter@sugarlabs.org>
* Added a Pie menu for Rhythm Maker * Remove accidentally committed .DS_Store files * Enable Type Functionality for Rhythm Maker * Moved the Piemenu code to piemenus.js * Ignore macOS .DS_Store files
* Fix auxiliary menu crash in non-English locales * Fix ESLint/Prettier formatting in js/activity.js
…abs#5018) * refactor: extract responsive breakpoint widths into constants - Add BREAKPOINT_TABLET (768px) and BREAKPOINT_MOBILE (600px) constants - Replace 5 hardcoded breakpoint values with named constants - Improves code maintainability and prevents magic numbers Affected lines: 769, 776, 787, 794, 856 in js/activity.js * changing to a much verbose variable name
Update Babel toolchain dependencies: - @babel/core: 7.11.1 → 7.28.5 - @babel/eslint-parser: 7.26.10 → 7.28.5 - @babel/preset-env: 7.11.0 → 7.28.5 - Remove deprecated babel-eslint package Fixes sugarlabs#5148 Part of sugarlabs#4668
- Remove unused variables in SaveInterface.js (savedNotationOutput, savedNotationNotes) - Remove legacy ES5 Object.keys fallback with const reassignment bug in logo.js - Fix superfluous arguments passed to __clear() function Follow-up to sugarlabs#4942 addressing Copilot code review suggestions. All changes verified with lint and full test suite (2275/2275 tests passed).
…5070) * Improve Tremolo block tooltip with parameter explanations * Improve Tremolo block tooltip for translation-friendliness
* fix: instant theme switching without page reload * Fix canvas background not updating on theme switch * Refactor theme application to use arrow functions * Refactor themebox test for consistency and clarity * Refactor getItem mock implementation in tests Refactor jest.spyOn for getItem to improve readability. * Refactor themebox test for improved readability * prettier --------- Co-authored-by: Walter Bender <walter@sorceo.com>
…ject helper (sugarlabs#4995) * refactor: replace unsafe eval with resolveObject helper in utils.js * refactor: replace safeEval's eval() with new Function() * revert: keep original eval in safeEval, focus PR on resolveObject only * refactor: move resolveObject to module scope * fix(utils): improve resolveObject error handling and environment support * fix(utils): add fallback resolution for nested class properties The resolveObject helper failed to resolve certain nested static class properties (e.g. Turtles.TurtlesView), resulting in missing methods such as doScale during initialization. This change adds a narrow fallback for cases where safe property resolution returns undefined, restoring previous behavior while keeping the primary resolution path intact. Addresses initialization failure reported during review. * style: apply prettier formatting to utils.js
…s#5165) * Fixed text color in light mode * fix: help widget in dark mode and overall text coloring * fix prettier formatting
Replace continuous 60fps stage.update() ticker with on-demand rendering using requestAnimationFrame and dirty flag pattern. The stage now only redraws when: 1) stageDirty flag is set 2) Active tweens exist 3) GIF animations are playing. This eliminates wasted CPU cycles when idle.
…abs#5144) * fix: correct spelling mistakes across JavaScript source files - abc.js: bounday→boundary, seperate→separate, doesnt→doesn't - activity.js: parameteres→parameters, horizonally→horizontally - basicblocks.js: verison→version - block.js: hightlight→highlight, unhightlight→unhighlight, collpase→collapse, eaiser→easier, Visiblity→Visibility - blocks.js: cick→click, integrety→integrity, Visiblity→Visibility, substraction→subtraction, unhilight→unhighlight, Porcess→Process, demoninator→denominator, propperly→properly - lilypond.js: bounday→boundary - logo.js: receievedArg→receivedArg - palette.js: simulataneously→simultaneously, stoped→stopped - pastebox.js: visibile→visible, debouce→debounce - protoblocks.js: overlayed→overlaid - turtle-singer.js: prvious→previous, substract→subtract, attatched→attached - turtledefs.js: auxillary→auxiliary * fix(blocks): update call sites to match renamed setActionProtoVisibility function Fixed typo 'setActionProtoVisiblity' -> 'setActionProtoVisibility' at three call sites (lines 2035, 3766, 5534) to match the renamed function definition. * fix typo * fix typo --------- Co-authored-by: Walter Bender <walter@sorceo.com>
* Compute slot size dynamically in SVG * Format blockfactory.js with Prettier
- Add _decorationBaseScale property to store image-based scale factor - Store scale factor in doTurtleShell when avatar image is set - Use stored scale factor in resizeDecoration instead of fixed 0.5 - Fix y-position in resizeDecoration (use 20 instead of 35) This fixes the bug where zooming the workspace after running an avatar block would cause the decoration image to grow huge and drift downward.
* Update PO, POT, and JSON files to standardize 'Media' and 'Sensors' labels * Fix 'media' and 'sensors' labels and inconsistencies
* pitch comparison for tied chords * chore: retrigger CI * chore: retrigger CI * chore: format js/turtle-singer.js with CI Prettier
- cssnano: 6.0.1 → 6.1.2 (minor update) - Remove clean-css: unused direct dependency (gulp-clean-css bundles its own) Part of sugarlabs#4668
…ugarlabs#4990) * Fix: Resolve p5/Tone.js conflict using adapter pattern * style: apply prettier formatting to adapter files
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Optimizes the _testConnectionType method in js/blocks.js by replacing a linear series of string comparisons with a constant-time Set lookup. This reduces complexity and improves maintainability.
- Remove global doSearch() call from index.html that was causing race condition - Add proper activity.doSearch() initialization in RequireJS domReady flow - Fix 2 failing Jest tests in abc.test.js by correcting expected string values - All 26 tests now pass (was 24 passing, 2 failing)
021nirav-blip
force-pushed
the
fix-doSearch-referenceerror
branch
from
20cd054 to
84c9c38
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions to a global utils.js file loaded early in the head.
synchronous jQuery call at the bottom of index.html.
traditional script execution order.
and Planet initialization.
@walterbender