chore(deps): migrate ESLint to v9 with flat config #5386
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
vanshika2720
force-pushed
the
chore/eslint-9-migration
branch
from
61b13ab to
e6069f0
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
vanshika2720
force-pushed
the
chore/eslint-9-migration
branch
from
e6069f0 to
24a50f0
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Hi @walterbender , this PR migrates the project to ESLint v9.19.0. Key Changes: Migrated from .eslintrc.json to the new Flat Config format ( Ran npx eslint js/**/*.js locally; all files are clean. |
eslint.config.mjs
Outdated
| "node_modules/**", | ||
| "bower_components/**", | ||
| "activity/**", | ||
| "planet/**", |
There was a problem hiding this comment.
Are we not linting the planet code?
… scope - Upgrade ESLint from v7.6.0 to v9.19.0 - Migrate from .eslintrc.json to eslint.config.mjs (flat config) - Add @eslint/js and globals packages for v9 compatibility - Update eslint plugins to compatible versions - Remove deprecated .eslintignore file Expand linting scope: - Change file pattern from js/**/*.js to **/*.js - Remove planet/** and activity/** from ignores - Add planet/libs/** to exclude only third-party libraries - Now linting planet/js/, activity/, and root files Bug fixes: - Fix invalid typeof comparison in msie_flashFallback/flashFallback.js - Add ES Module support for Cypress files - Fix no-loss-of-precision warnings in test constants - Add missing semicolon in cypress/support/e2e.js Verification: - npm run lint: 0 errors, 383 warnings (pre-existing) - All planet/ and activity/ code now properly linted
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
|
✅ All Jest tests passed! This PR is ready to merge. |
vanshika2720
force-pushed
the
chore/eslint-9-migration
branch
from
0b7ce0f to
266c939
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Hi @walterbender, Good catch! Updated the config to lint planet/ code. Removed planet/** from ignores (kept planet/libs/** for third-party libs only) and broadened the file pattern to **/*.js. Verified planet/js/*.js and activity/SugarAnimation.js are now linted with 0 errors. All checks passing! |
|
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
|
✅ All Jest tests passed! This PR is ready to merge. |
vanshika2720
force-pushed
the
chore/eslint-9-migration
branch
from
178e2c2 to
affad55
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
2 participants
Summary
Migrate ESLint from v8.57.1 to v9.19.0 with the new Flat Config format.
Implementation Details
@eslint/jsto supply recommended rules.globalspackage to explicitly define browser, node, and jest environments.Verification Results
npm run lintand confirmed all legacy rules are correctly enforced.Closes #5381 #5369 #5364