-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(pnpm): add support for configDependencies #40592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huyhua-nvg
wants to merge
8
commits into
renovatebot:main
Choose a base branch
from
huyhua-nvg:feat/pnpm-add-config-dependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(pnpm): add support for configDependencies #40592
huyhua-nvg
wants to merge
8
commits into
renovatebot:main
from
huyhua-nvg:feat/pnpm-add-config-dependencies
+636
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@viceice sorry about that. I messed up by force pushing and those PRs were autoclosed. |
Member
you can reopen after auto closing as long it's not merged |
1 similar comment
Member
you can reopen after auto closing as long it's not merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request adds comprehensive support for pnpm's
configDependenciesto the npm manager, enabling extraction, parsing, and updating of these dependencies inpnpm-workspace.yamlfiles. It also enhances the handling of npm package metadata by extractingintegrityandtarballfields, and improves the robustness of file extraction logic. The changes are covered by extensive new tests to ensure correct behavior.Support for pnpm configDependencies:
configDependenciesfrompnpm-workspace.yaml, supporting both string and object formats. This includes schema updates, extraction logic, and new tests to cover various scenarios. [1] [2] [3] [4] [5] [6] [7]configDependenciesentries, handling both scalar and object forms, including updatingintegrityandtarballfields as appropriate. Thoroughly tested with a variety of edge cases. [1] [2] [3] [4] [5]NPM package metadata improvements:
integrityandtarballfields from package metadata, storing them asnewDigestanddownloadUrlin release objects. [1] [2] [3]File extraction logic improvements:
These changes ensure that Renovate can fully manage pnpm config dependencies, providing accurate updates and metadata extraction for advanced pnpm workflows.
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: