Skip to content

Conversation

@secustor
Copy link
Member

Changes

Moving away from Volta.sh as it is officially unmaintained.
They are recommending Mise and as we are supporting it with Renovate I think we should follow their advice.

https://mise.jdx.dev/mise-cookbook/nodejs.html#example-with-pnpm

Context

Please select one of the following:

  • This closes an existing Issue,
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

# https://mise.jdx.dev/mise-cookbook/nodejs.html#example-with-pnpm
[tools]
# we could configure Mise to reuse `.nvmrc`, though that feature is opting in via `mise settings add idiomatic_version_file_enable_tools node`
node = "24.13.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a test to ensure they are in sync

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are auto updating this via Renovate, any specific concerns so that we need additional tests?

The depNames are nodejs ( mise manager) vs node ( nvm manager )
Though I agree we should broaden group:nodejs to cover nodejs so it is handled in a single PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


[hooks]
# Enabling corepack will install the `pnpm` package manager specified in package.json#packageManager
postinstall = 'npx corepack enable'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't it support install pnpm? pnpm will ensure proper version from package.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly, this is basically their cookbook see line 1

Though corepack will use the packageManager field which we keep up to date

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so do not use mise for me as it will break my existing setup 😏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity what do you use for version management of pnpm if not corepack?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install pnpm globally and let pnpm handle it similar to corepack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants