-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore: move from volta.sh to mise #40567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| # https://mise.jdx.dev/mise-cookbook/nodejs.html#example-with-pnpm | ||
| [tools] | ||
| # we could configure Mise to reuse `.nvmrc`, though that feature is opting in via `mise settings add idiomatic_version_file_enable_tools node` | ||
| node = "24.13.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add a test to ensure they are in sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are auto updating this via Renovate, any specific concerns so that we need additional tests?
The depNames are nodejs ( mise manager) vs node ( nvm manager )
Though I agree we should broaden group:nodejs to cover nodejs so it is handled in a single PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name will be changed soon
|
|
||
| [hooks] | ||
| # Enabling corepack will install the `pnpm` package manager specified in package.json#packageManager | ||
| postinstall = 'npx corepack enable' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't it support install pnpm? pnpm will ensure proper version from package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly, this is basically their cookbook see line 1
Though corepack will use the packageManager field which we keep up to date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so do not use mise for me as it will break my existing setup 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity what do you use for version management of pnpm if not corepack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
install pnpm globally and let pnpm handle it similar to corepack
Changes
Moving away from Volta.sh as it is officially unmaintained.
They are recommending Mise and as we are supporting it with Renovate I think we should follow their advice.
https://mise.jdx.dev/mise-cookbook/nodejs.html#example-with-pnpm
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: