-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: port Ubuntu versioning support to Debian container images #40499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
107cb22 to
c0df406
Compare
viceice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing coverage
a3a1327 to
c3845a4
Compare
|
I added a small test to cover the two lines that were missing. It should be ready to merge now. |
Resolves renovatebot#27862. Signed-off-by: Alexander Gil <pando855@gmail.com>
5b0e3b5 to
03831d6
Compare
Signed-off-by: Alexander Gil <pando855@gmail.com>
03831d6 to
7f649d7
Compare
|
Finally, all green. Ping @viceice |
| ${'buster-20220101'} | ${'buster'} | ||
| ${'bullseye-20220101'} | ${'bullseye'} | ||
| ${'bookworm-20230816'} | ${'bookworm'} | ||
| ${'bookworm-20230816.1'} | ${'bookworm'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we return the codename but in the previous isDatedCodename we return false for buster-20220101.123..why this difference ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand your question.
buster-20220101.123 doesn't match the regex /^(?<codename>\w+)-(?<date>\d{8})(?<suffix>\.\d{1,2})?$/ so it returns false and null. On the other hand, bookworm-20230816.1 matches and it returns true and bookworm.
Resolves #27862.
Changes
Added support for dated container image version formats in Debian versioning, similar to existing Ubuntu support. This includes parsing, validation, stability checks, and comparison logic for versions like
bookworm-20230816andbullseye-20220101.2.Key changes:
isDatedCodeNameto validate codenames against Debian distro infoDebianVersioningApiwith dated version handling inisValid,isStable,_parse,equals, andisGreaterThanContext
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: N/A (local development)