-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(datasource): add GraalVM version datasource #40497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@zeitlinger once you've had a chance to accept the CLA and take a look at the code coverage, can you please also make sure you've followed our PR template? Thanks! |
|
@jamietanna done |
|
PR template? |
added |
… and JRE releases
… and JRE releases
… and JRE releases
… and JRE releases
… and JRE releases
d1216c4 to
1a63627
Compare
|
@jamietanna can you check again? |
viceice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to integrate it into the java-version datasource
Changes
Adds a new
graalvm-versiondatasource to fix compatibility issues with Oracle GraalVM versions in the mise manager.Context
The mise manager currently uses
JavaVersionDatasource(Adoptium API) for all Java variants, includingoracle-graalvm-*prefixes. However, Adoptium API versions are incompatible with GraalVM, causing failures likeprometheus/client_java#1734.
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository:
Solution
Created a new
graalvm-versiondatasource that:oracle-graalvm) and image type (jdk/jre)Package naming format:
oracle-graalvm-jdk?system=true- Auto-detect current systemoracle-graalvm-jre?os=macosx&architecture=aarch64- Explicit platformoracle-graalvm-jdk?releaseType=ea- Early access releasesSystem detection mappings:
ia32→i686,x64→x86_64,arm64→aarch64,arm→arm32darwin→macosx,win32→windows,linux→linuxChanges
New files:
lib/modules/datasource/graalvm-version/index.ts- Main datasource implementationlib/modules/datasource/graalvm-version/common.ts- System detection utilitieslib/modules/datasource/graalvm-version/schema.ts- Zod validationlib/modules/datasource/graalvm-version/types.ts- TypeScript typeslib/modules/datasource/graalvm-version/readme.md- Documentationlib/modules/datasource/graalvm-version/*.spec.ts- Comprehensive testslib/modules/datasource/graalvm-version/__fixtures__/- Test fixturesModified files:
lib/modules/datasource/api.ts- Registered new datasourcelib/modules/manager/mise/upgradeable-tooling.ts- Updated oracle-graalvm to use new datasourcelib/modules/manager/mise/extract.spec.ts- Updated test expectationslib/util/cache/package/namespaces.ts- Added cache namespaceTest Plan
Verification:
References
🤖 This PR was written primarily by Claude Code.