-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(bazel-module): add Crate dependency extraction #40393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
19a4da6 to
cbc3a00
Compare
c57a95c to
2db9efb
Compare
|
conflictet |
|
fixed |
|
|
||
| const dep: PackageDependency<CargoManagerData> = { | ||
| datasource: CrateDatasource.id, | ||
| versioning: 'semver', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| versioning: 'semver', |
why? crate datasource is setting crate versioning which is a little different than semver
| override defaultVersioning = cargoVersioning.id; |
| path = "/var/crate", | ||
| ) | ||
| crate.spec( | ||
| package = "no_version_crate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this work on bazel? if yes it should set no version instead of invalid
| ``` | ||
|
|
||
| ```starlark | ||
| crate_1 = use_extension("@rules_rust//crate_universe:extension.bzl", "crate") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not clear, is this supported or not
Changes
Some project that are using
bazelcan useMODULE.bazelto manage their Crate dependencies, without having aCargo.tomlfile in their repo.Renovate should be add to extract Cargo dependencies within
MODULE.bazel.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: clementguillot/testbazel#13
Under
bazel-module (1)section, you can find 3 Cargo dependencies:axum,tokioandtower.PR from this version of Renovate: clementguillot/testbazel#14