test(onboarding/branch/check): clarify why no comment when there's a closed PR #40328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…closed PR As it may be surprising that there's no comment in this function call, but it's because we handle the commenting in `ensureOnboardingPr`.
jamietanna
force-pushed
the
test/clarify
branch
from
a235553 to
d3e40a3
Compare
jamietanna
commented
Jan 8, 2026
|
|
||
| // incase pr was autolcosed becasue if it passing the onboardingAutoCloseAge | ||
| // in the case that the PR was autoclosed as it passes `onboardingAutoCloseAge` | ||
| it('continues with normal logic if closedPr exists - skips closing comment', async () => { |
Contributor
Author
There was a problem hiding this comment.
Maybe also:
Suggested change
| it('continues with normal logic if closedPr exists - skips closing comment', async () => { | |
| it('continues with normal logic if closedPr exists - skips closing comment when past onboardingAutoCloseAge', async () => { |
?
RahulGautamSingh
suggested changes
Jan 8, 2026
| }); | ||
|
|
||
| // incase pr was autolcosed becasue if it passing the onboardingAutoCloseAge | ||
| // in the case that the PR was autoclosed as it passes `onboardingAutoCloseAge` |
Collaborator
There was a problem hiding this comment.
Suggested change
| // in the case that the PR was autoclosed as it passes `onboardingAutoCloseAge` | |
| // in the case that the PR was autoclosed as it passes the `onboardingAutoCloseAge` |
| await expect(isOnboarded(config)).rejects.toThrow( | ||
| REPOSITORY_CLOSED_ONBOARDING, | ||
| ); | ||
| // NOTE that that no comment is added, because it is handled as part of `ensureOnboardingPr` |
Collaborator
There was a problem hiding this comment.
Suggested change
| // NOTE that that no comment is added, because it is handled as part of `ensureOnboardingPr` | |
| // NOTE that no comment is added, because it is handled as part of `ensureOnboardingPr` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As it may be surprising that there's no comment in this function call,
but it's because we handle the commenting in
ensureOnboardingPr.Context
Please select one of the below:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: