fix(apple): disable ASAN for JSC methods #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming an internal change we made to JSCRuntime.cpp that I'm fairly confident in.
--- Original PR notes ---
ASAN stores stack values in a shadow stack separate from the "true" stack of the thread, which prevents JavaScriptCore's GC from finding those values. This can lead to premature freeing of objects and weird crashes.
Thankfully, we don't directly talk to JSC. We only talk to it through JSI which only ever briefly keeps JSC values on the stack, and only in very specific functions/methods. Instead of turning off ASAN or its stack use-after-free checking for the entire process, we can annotate just those few spots in JSI to tell Clang to avoid ASAN instrumentation for them to avoids these GC issues while keeping ASAN on everywhere else.
This change does not impact shipping bits. It uses an #if to ensure only builds with ASAN enabled (i.e., debug) are impacted.