Skip to content

Conversation

@zooba
Copy link
Member

@zooba zooba commented Jan 27, 2026

In particular, this allows defining in to NULL, which has the effect of disabling automatic .pyc caching.
We also update tests to handle the cache tag being None, which was always allowed, but was not accounted for in tests.

… sys.implementation.cache_tag.

This has the effect of disabling automatic .pyc caching.
@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label Jan 27, 2026
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jan 27, 2026
@zooba zooba changed the title gh-144278: Enable defining _PY_DISABLE_SYS_CACHE_TAG to disable sys.implementation.cache_tag gh-144278: Enable overriding TAG (sys.implementation.cache_tag) when building sysmodule.c Jan 28, 2026
@hugovk hugovk removed their request for review January 28, 2026 18:01
@zooba
Copy link
Member Author

zooba commented Jan 29, 2026

If anyone stumbles into here and has any idea why execution is 2-3x slower when cache_tag is None, I'd love to hear about it. The test failures/cancellations are timeouts/time-sensitivity issues, not poor functionality, but I can't come up with any reason why it would be so much slower.

@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 30, 2026
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zooba for commit c277edb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144293%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 30, 2026
@zooba
Copy link
Member Author

zooba commented Jan 30, 2026

So it's looking like our compiler is now slow enough that the test suite can't finish within timeouts without cached bytecode. Running with the buildbots for a broader view including PGO/etc., but it's possible the answer is just going to have to be to run with longer timeouts to see the results. Or optimise the compiler a bit.

FWIW, on my own (fairly slow) Windows PC, the difference isn't anywhere near as bad as in CI.

@zooba zooba removed the docs Documentation in the Doc dir label Jan 30, 2026
@zooba zooba marked this pull request as draft January 30, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants