-
-
Notifications
You must be signed in to change notification settings - Fork 34k
gh-144278: Enable overriding TAG (sys.implementation.cache_tag) when building sysmodule.c #144293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… sys.implementation.cache_tag. This has the effect of disabling automatic .pyc caching.
|
If anyone stumbles into here and has any idea why execution is 2-3x slower when |
|
🤖 New build scheduled with the buildbot fleet by @zooba for commit c277edb 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144293%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
So it's looking like our compiler is now slow enough that the test suite can't finish within timeouts without cached bytecode. Running with the buildbots for a broader view including PGO/etc., but it's possible the answer is just going to have to be to run with longer timeouts to see the results. Or optimise the compiler a bit. FWIW, on my own (fairly slow) Windows PC, the difference isn't anywhere near as bad as in CI. |
In particular, this allows defining in to NULL, which has the effect of disabling automatic .pyc caching.
We also update tests to handle the cache tag being None, which was always allowed, but was not accounted for in tests.