feat(core): Add workflow history update endpoint (no-changelog) #25043
+459
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
This comment has been minimized.
This comment has been minimized.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 11 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/cli/src/workflows/workflow-history/workflow-history.service.ts">
<violation number="1" location="packages/cli/src/workflows/workflow-history/workflow-history.service.ts:145">
P2: updateVersionForUser authorizes using only `workflow:read` via getVersion, so users with read access can update workflow history metadata. Consider requiring `workflow:update` (or a write-capable check) before calling updateVersion.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| updateData: UpdateWorkflowHistoryVersionDto, | ||
| ) { | ||
| // Check rights and ensure version exists | ||
| await this.getVersion(user, workflowId, versionId, { includePublishHistory: false }); |
Contributor
There was a problem hiding this comment.
P2: updateVersionForUser authorizes using only workflow:read via getVersion, so users with read access can update workflow history metadata. Consider requiring workflow:update (or a write-capable check) before calling updateVersion.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/cli/src/workflows/workflow-history/workflow-history.service.ts, line 145:
<comment>updateVersionForUser authorizes using only `workflow:read` via getVersion, so users with read access can update workflow history metadata. Consider requiring `workflow:update` (or a write-capable check) before calling updateVersion.</comment>
<file context>
@@ -134,8 +135,24 @@ export class WorkflowHistoryService {
+ updateData: UpdateWorkflowHistoryVersionDto,
+ ) {
+ // Check rights and ensure version exists
+ await this.getVersion(user, workflowId, versionId, { includePublishHistory: false });
+
+ await this.updateVersion(workflowId, versionId, updateData);
</file context>
Bundle ReportBundle size has no change ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
Closes ADO-4730
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)