feat: Trigger validation service #25037
Open
+626
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trigger-validation-service
michael-radency
added
core
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…trigger-validation-service
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
Found 45 test failures on Blacksmith runners: Failures
|
|
Found 45 test failures on Blacksmith runners: Failures
|
mfsiega
reviewed
Jan 29, 2026
Contributor
mfsiega
left a comment
mfsiega
left a comment
There was a problem hiding this comment.
I really like the general approach!
I do worry that there are a lot of tricky corner cases.
Haven't taken a full look line-by-line yet.
| * Parameters that must be unique across all active workflows, keyed by trigger type. | ||
| */ | ||
| export const TRIGGERS_UNIQUE_PARAMETERS: Record<string, string[]> = { | ||
| 'n8n-nodes-base.kafkaTrigger': ['groupId'], |
Contributor
There was a problem hiding this comment.
Strictly speaking we still can't prevent this, because we support expressions, right? But of course it helps if somebody does this accidentally.
Contributor
Author
There was a problem hiding this comment.
true, but I do think that this is unlikely, as it isfor triggers
| // Check whether this workflow is active. | ||
| const workflowIsActive = await this.workflowRepository.isActive(payload.workflowData.id); | ||
|
|
||
| const triggerToStartFrom = |
Contributor
There was a problem hiding this comment.
I think we probably want to move this lower, down around line 221? Since in between here and there we do some work to potentially choose the relevant trigger (e.g., if it's a partial execution to a destination node, we pick a trigger on the backend).
There's also the question of pinned data - if we have pinned data for the trigger we won't actually end up activating it. So in that case, I think we would want to allow it.
| return false; | ||
| } | ||
|
|
||
| await this.triggerValidation.validateWorkflowActivation(workflow); |
Contributor
There was a problem hiding this comment.
We have some existing validation in the WorkflowService.activateWorkflow, which I think is a slightly better place for this. Should it live there instead? (And maybe we can unify some of the logic a bit?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a centralized trigger validation system that enforces constraints on specific trigger types during workflow execution and activation.
Changes
New Trigger Configuration Constants
Added two constants in
trigger-validation.service.ts:TRIGGERS_PREVENT_TEST_WHILE_ACTIVE- ASet<string>defining trigger types that cannot run test/manual executions while the workflow is active. This addresses limitations in certain triggers (e.g., Kafka) where simultaneous production and test listeners cause conflicts.TRIGGERS_UNIQUE_PARAMETERS- ARecord<string, string[]>mapping trigger types to parameter names that must be unique across all active workflows. This prevents resource conflicts (e.g., two active workflows cannot share the same Kafka consumer group ID).Validation Service
The
TriggerValidationServiceprovides two main validation methods:validateManualExecution()- Called before test/manual runs to:validateWorkflowActivation()- Called before workflow activation to:Error Handling
SingleTriggerError- RenamedSingleWebhookTriggerError, thrown when attempting to test a restricted trigger while the workflow is activeTriggerParameterConflictError- Thrown when a parameter value conflicts with an active workflowExample Configuration
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-4323/trigger-validation-service
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)