Skip to content

Conversation

@mfsiega
Copy link
Contributor

@mfsiega mfsiega commented Jan 29, 2026

Summary

Allow manual executions with neither start node or destination node.

WIP. Still need to do something with the request types to reflect this (either introduce a new variant, or update the existing one).

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/cli/src/workflows/workflow-execution.service.ts">

<violation number="1" location="packages/cli/src/workflows/workflow-execution.service.ts:139">
P1: Rule violated: **Security Review**

Logging the entire manual execution payload leaks workflow data and credentials to server logs. Remove this debug log or log only non-sensitive metadata to comply with credential-handling requirements.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

}
}

console.log(payload);
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Rule violated: Security Review

Logging the entire manual execution payload leaks workflow data and credentials to server logs. Remove this debug log or log only non-sensitive metadata to comply with credential-handling requirements.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/cli/src/workflows/workflow-execution.service.ts, line 139:

<comment>Logging the entire manual execution payload leaks workflow data and credentials to server logs. Remove this debug log or log only non-sensitive metadata to comply with credential-handling requirements.</comment>

<file context>
@@ -136,6 +136,8 @@ export class WorkflowExecutionService {
 			}
 		}
 
+		console.log(payload);
+
 		// Case 2: Full execution from a known trigger.
</file context>
Fix with Cubic

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@blacksmith-sh
Copy link

blacksmith-sh bot commented Jan 29, 2026

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
tests/e2e/app-config/demo.spec.ts/Demo › can import template View Logs

Fix in Cursor

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants