Skip to content

Conversation

@guillaumejacquart
Copy link
Contributor

Summary

Addresses performance degradation when working with large user lists by removing unlimited database queries (take: -1) and implementing proper filtering.

Changes

Backend:

Add filter capabilities (by ids, or by pending state) on the users controller to enable better filter targeting on the front.

Editor:
Added remote, remoteMethod, and loading props for paginated user loading. Maintains backwards compatibility with local filtering mode.
Removed useless calls to users.
Transformed global fetch of all users to targeted fetch with filtering

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/IAM-158/community-issue-performance-degradation-while-big-users-count

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@guillaumejacquart guillaumejacquart force-pushed the iam-158-community-issue-performance-degradation-while-big-users branch from 047f920 to 93234f9 Compare January 29, 2026 09:54
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

@blacksmith-sh

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Bundle Report

Changes will increase total bundle size by 40.94MB (100.0%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
editor-ui-esm 40.94MB 40.94MB (100%) ⬆️⚠️

@codecov
Copy link

codecov bot commented Jan 29, 2026

Bundle Report

Changes will increase total bundle size by 40.98MB (100.0%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
editor-ui-esm 40.98MB 40.98MB (100%) ⬆️⚠️

@guillaumejacquart guillaumejacquart marked this pull request as ready for review January 29, 2026 13:42
@guillaumejacquart guillaumejacquart requested review from a team, BGZStephen, afitzek, cstuncsik and phyllis-noester and removed request for a team January 29, 2026 13:42
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 17 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/frontend/editor-ui/src/features/workflows/workflowHistory/views/WorkflowHistory.vue">

<violation number="1" location="packages/frontend/editor-ui/src/features/workflows/workflowHistory/views/WorkflowHistory.vue:117">
P1: Rule violated: **Prefer Typeguards over Type casting**

Replace the type assertion with a type guard. Rule 1 forbids `as` for type narrowing; use a predicate to narrow to string instead.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants