fix(core): Let routing nodes reference execution id #25022
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 49 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
4 issues found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/core/src/execution-engine/routing-node.ts">
<violation number="1" location="packages/core/src/execution-engine/routing-node.ts:757">
P0: Rule violated: **Security Review**
**Critical security issue**: Debug `console.log` statements are logging decrypted credentials to console/stdout. The `additionalKeys` parameter can contain `$credentials` with decrypted API keys, tokens, and secrets. Remove all debug logging before merging.</violation>
<violation number="2" location="packages/core/src/execution-engine/routing-node.ts:771">
P1: Rule violated: **Security Review**
**Security issue**: Debug `console.log` is logging resolved expression values which may contain sensitive credential data or secrets. Remove debug logging before merging.</violation>
<violation number="3" location="packages/core/src/execution-engine/routing-node.ts:866">
P2: Rule violated: **Security Review**
Debug `console.log` statements should be removed before merging. These appear to be leftover debugging code (e.g., `'here for some reason'` message).</violation>
<violation number="4" location="packages/core/src/execution-engine/routing-node.ts:1094">
P1: Rule violated: **Security Review**
**Security issue**: Debug `console.log` is logging request options which may contain authentication headers, tokens, and sensitive request body data. Remove debug logging before merging.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| (typeof parameterValue === 'string' && parameterValue.charAt(0) === '=') | ||
| ) { | ||
| console.log('Resolving parameter value:', parameterValue); | ||
| console.log('With additional keys:', additionalKeys); |
Contributor
There was a problem hiding this comment.
P0: Rule violated: Security Review
Critical security issue: Debug console.log statements are logging decrypted credentials to console/stdout. The additionalKeys parameter can contain $credentials with decrypted API keys, tokens, and secrets. Remove all debug logging before merging.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/core/src/execution-engine/routing-node.ts, line 757:
<comment>**Critical security issue**: Debug `console.log` statements are logging decrypted credentials to console/stdout. The `additionalKeys` parameter can contain `$credentials` with decrypted API keys, tokens, and secrets. Remove all debug logging before merging.</comment>
<file context>
@@ -753,8 +753,10 @@ export class RoutingNode {
(typeof parameterValue === 'string' && parameterValue.charAt(0) === '=')
) {
+ console.log('Resolving parameter value:', parameterValue);
+ console.log('With additional keys:', additionalKeys);
const { node, workflow, mode, connectionInputData, runExecutionData } = this.context;
- return workflow.expression.getParameterValue(
</file context>
| executeData, | ||
| returnObjectAsString, | ||
| ); | ||
| console.log('Resolved to:', val); |
Contributor
There was a problem hiding this comment.
P1: Rule violated: Security Review
Security issue: Debug console.log is logging resolved expression values which may contain sensitive credential data or secrets. Remove debug logging before merging.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/core/src/execution-engine/routing-node.ts, line 771:
<comment>**Security issue**: Debug `console.log` is logging resolved expression values which may contain sensitive credential data or secrets. Remove debug logging before merging.</comment>
<file context>
@@ -766,6 +768,8 @@ export class RoutingNode {
executeData,
returnObjectAsString,
);
+ console.log('Resolved to:', val);
+ return val;
}
</file context>
| } | ||
| } | ||
| } | ||
| console.log('Returning request options:', returnData); |
Contributor
There was a problem hiding this comment.
P1: Rule violated: Security Review
Security issue: Debug console.log is logging request options which may contain authentication headers, tokens, and sensitive request body data. Remove debug logging before merging.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/core/src/execution-engine/routing-node.ts, line 1094:
<comment>**Security issue**: Debug `console.log` is logging request options which may contain authentication headers, tokens, and sensitive request body data. Remove debug logging before merging.</comment>
<file context>
@@ -1069,6 +1091,7 @@ export class RoutingNode {
}
}
}
+ console.log('Returning request options:', returnData);
return returnData;
}
</file context>
| } | ||
|
|
||
| if (nodeProperties.routing.send) { | ||
| console.log('here for some reason'); |
Contributor
There was a problem hiding this comment.
P2: Rule violated: Security Review
Debug console.log statements should be removed before merging. These appear to be leftover debugging code (e.g., 'here for some reason' message).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/core/src/execution-engine/routing-node.ts, line 866:
<comment>Debug `console.log` statements should be removed before merging. These appear to be leftover debugging code (e.g., `'here for some reason'` message).</comment>
<file context>
@@ -842,6 +863,7 @@ export class RoutingNode {
}
if (nodeProperties.routing.send) {
+ console.log('here for some reason');
let propertyName = nodeProperties.routing.send.property;
if (propertyName !== undefined) {
</file context>
|
Found 99 test failures on Blacksmith runners: Failures
|
n8n-assistant
bot
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-1777
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)