-
Notifications
You must be signed in to change notification settings - Fork 117
Use flat data structure to store lists of points #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jush
wants to merge
31
commits into
main
Choose a base branch
from
rs/primitives-geojson
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,702
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
services-geojson/src/main/java/com/mapbox/geojson/FlattenListOfPoints.java
Show resolved
Hide resolved
jush
commented
Jan 27, 2026
services-geojson/src/main/java/com/mapbox/geojson/FlattenListOfPoints.java
Outdated
Show resolved
Hide resolved
3e5fd48 to
ef71786
Compare
jush
commented
Jan 30, 2026
| * @see <a href="https://github.com/googlemaps/android-maps-utils/blob/master/library/src/com/google/maps/android/PolyUtil.java">Part of algorithm came from this source.</a> | ||
| */ | ||
| @NonNull | ||
| public static double[] decodeToFlattenListOfPoints( |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a copy paste of above public static List<Point> decode(..) except that it internally uses arrays of doubles that grow (doubles in size) as needed.
jush
commented
Jan 30, 2026
This reverts commit 1007965.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main difference is the introduction of
FlattenListOfPointswhich is able to store a list of coordinate points (latitude, longitude, altitude, bounding box) as a collection of arrays.Also avoid using
List<Point>and instead usedouble []to avoid extra memory use.This change improves memory usage significantly:
It also unlocks the possibility to use JNI#GetArrayElements to access the array in one JNI call.
I have deprecated the
LineString#coordinates()andPoint#coordinates(). They can still be used but let's encourage the use of the flat structure or direct calls tolongitude(),latitude(),altitude()in case ofPoint.To avoid breaking things a new interface
FlattenedCoordinateContaineris added to support the newflattenCoordinates()method used in serialization code that inherits from the already existingCoordinateContainer.BaseGeometryTypeAdapteris modified to support this new container (methodwriteFlattenedCoordinateContainer()).Also the unit tests are extended to cover the new logic plus improve older tests.