Skip to content

Improve badge dropdown behavior with auto-close and smooth animations #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Katotodan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve badge dropdown behavior with auto-close and smooth animations #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbd36ac
Enhance badge dropdown behavior
Katotodan Jan 26, 2026
6761c27
Enhance badge dropdown behavior
Katotodan Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions src/reusecore/Accordion/accordion.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,6 @@ import {
AccordionItemPanel,
} from "react-accessible-accordion";

const fadeIn = keyframes`
0% {
opacity: 0;
}
100% {
opacity: 1;
}
`;

export const AccordionWrapper = styled(Accordion)``;

export const AccordionItemWrapper = styled(AccordionItem)``;
Expand Down Expand Up @@ -56,9 +47,26 @@ export const AccordionItemButtonWrapper = styled(AccordionItemButton)`
padding: 0.625rem 1.5rem 0.625rem 1.5rem;
`;
export const AccordionBodyWrapper = styled(AccordionItemPanel)`
animation: 0.35s ${fadeIn} ease-in;
&.accordion__body--hidden {
animation: 0.35s ${fadeIn} ease-in;
overflow: hidden;
display: grid;
grid-template-rows: 1fr;
transition: grid-template-rows ease 1.0s;

> .inner {
min-height: 0;
visibility: visible;
opacity: 1;
transition: opacity 0.35s;
}

&[hidden] {
grid-template-rows: 0fr;

> .inner {
visibility: hidden;
opacity: 0;
transition: opacity 0.35s, visibility 0s 0.35s;
}
}
`;

Expand Down
14 changes: 8 additions & 6 deletions src/sitecomponents/Faq/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const Faq = (props) => {

return (
<FaqSectionWrapper>
<Accordion allowMultipleExpanded="true" allowZeroExpanded="true">
<Accordion allowMultipleExpanded={false} allowZeroExpanded={true}>
{faq_keys.map((key) => (
<>
{faqs[key].map((faq, index) => (
Expand All @@ -58,11 +58,13 @@ const Faq = (props) => {
</IconWrapper>
</AccordionTitle>
<AccordionBody>
{
faq.answer.length >= 1 ? <ul>{faq.answer.map((ans, id) => (<li key={id}><p key={id}>{ans}</p></li>))}</ul> : <br />
}
<div className="faqbutton">
{faq.link && <Button primary className="faqbutton" url={faq.link} title={faq.linktext} external={false} />}
<div className="inner">
{
faq.answer.length >= 1 ? <ul>{faq.answer.map((ans, id) => (<li key={id}><p key={id}>{ans}</p></li>))}</ul> : <br />
}
<div className="faqbutton">
{faq.link && <Button primary className="faqbutton" url={faq.link} title={faq.linktext} external={false} />}
</div>
</div>
</AccordionBody>
</AccordionItem>
Expand Down