Skip to content

Conversation

@camilamacedo86
Copy link
Member

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Helm chart NOTES.txt scaffold to the helm/v2-alpha plugin so generated charts include a post-install message, and updates docs/testdata accordingly.

Changes:

  • Scaffold templates/NOTES.txt during Helm chart generation (with --force overwrite behavior).
  • Add unit tests for the new Notes template scaffold (Ginkgo suite + specs).
  • Update plugin documentation and generated testdata charts to include NOTES.txt.

Reviewed changes

Copilot reviewed 5 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
testdata/project-v4-with-plugins/dist/chart/templates/NOTES.txt Expected generated Helm chart notes output for testdata project.
pkg/plugins/optional/helm/v2alpha/scaffolds/internal/templates/chart-templates/suite_test.go Adds a Ginkgo suite for the charttemplates package tests.
pkg/plugins/optional/helm/v2alpha/scaffolds/internal/templates/chart-templates/notes_test.go Adds unit tests validating Notes scaffold path, overwrite behavior, and template content.
pkg/plugins/optional/helm/v2alpha/scaffolds/internal/templates/chart-templates/notes.go Implements the Notes scaffold that generates templates/NOTES.txt.
pkg/plugins/optional/helm/v2alpha/scaffolds/edit_kustomize.go Wires the new Notes scaffold into the standard chart file generation flow.
docs/book/src/plugins/available/helm-v2-alpha.md Documents the new NOTES.txt behavior and chart structure updates.
docs/book/src/multiversion-tutorial/testdata/project/dist/chart/templates/NOTES.txt Updates tutorial testdata chart output to include NOTES.txt.
docs/book/src/getting-started/testdata/project/dist/chart/templates/NOTES.txt Updates tutorial testdata chart output to include NOTES.txt.
docs/book/src/cronjob-tutorial/testdata/project/dist/chart/templates/NOTES.txt Updates tutorial testdata chart output to include NOTES.txt.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants