-
Notifications
You must be signed in to change notification settings - Fork 354
Migrate from pyproject.toml to jac.toml #4209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrate from pyproject.toml to jac.toml #4209
Conversation
…guration and implement editable installation support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements a migration from pyproject.toml to jac.toml for Jac project configuration. It introduces a new pip-style editable installer that allows installing Jac projects in development mode using jac pip-install, similar to pip install -e .. The installer temporarily generates a pyproject.toml from the jac.toml configuration to work with pip's editable install mechanism.
Changes:
- Added new
JacPipInstallerclass for editable project installation with support for extras and dev dependencies - Extended
DependencyInstaller._run_pip()with parameters for working directory, verbose output, and streaming modes - Implemented new CLI command
jac pip-installwith support for path, dev dependencies, extras, and verbose output - Migrated jac-byllm package from
pyproject.tomltojac.tomlas a reference example
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| jac/jaclang/project/pip_installer.jac | Interface definition for the new JacPipInstaller class and helper functions |
| jac/jaclang/project/impl/pip_installer.impl.jac | Implementation of editable installer with pyproject.toml generation from jac.toml |
| jac/jaclang/project/dependencies.jac | Extended _run_pip signature to support cwd, verbose, and stream_output parameters |
| jac/jaclang/project/impl/dependencies.impl.jac | Updated _run_pip implementation to handle new parameters for streaming output |
| jac/jaclang/cli/commands/project.jac | Added pip-install command declaration with arguments for path, dev, extras, no_deps, and verbose |
| jac/jaclang/cli/commands/impl/project.impl.jac | Implemented pip_install command with project discovery, config loading, and installer invocation |
| jac-byllm/pyproject.toml | Removed deprecated pyproject.toml configuration file |
| jac-byllm/jac.toml | New jac.toml configuration file with all project metadata and dependencies |
…ith dev and optional dependencies
…editable install setup
Add jac pip-install command for pip-style editable installation
Implements a new
jac pip-installcommand that provides pip-style editable installation for Jac projects, similar topip install -e .but usingjac.tomlconfiguration instead ofpyproject.tomlKey Features:
--dev,-e <group>)pyproject.tomlTest cases