Skip to content

Conversation

@curefat
Copy link

@curefat curefat commented Jan 30, 2026

This update introduces support for MCP tools with parametersJsonSchema in LangChain4j, enhancing the tool specification handling. Additionally, code readability is improved by refactoring several sections for clarity and consistency.

This update introduces the ability to handle MCP tools that utilize parametersJsonSchema for defining tool specifications. The implementation includes logic to convert JSON schema objects to Schema instances and updates the corresponding tests to ensure correct functionality.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @curefat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances LangChain4j's capabilities by integrating support for MCP tools that utilize parametersJsonSchema for defining their function parameters. This change improves the flexibility and compatibility of tool handling within the framework, allowing for a broader range of tool specifications to be processed correctly. The update also includes minor code readability improvements and robust testing to ensure the new functionality works as expected.

Highlights

  • MCP Tool Support: Introduced support for MCP (Multi-Cloud Platform) tools that define their parameters using parametersJsonSchema within LangChain4j.
  • Flexible Schema Handling: The system now intelligently handles parametersJsonSchema which can be provided either as a raw JSON object (Map) or as a pre-parsed Schema object, converting it to a Schema for consistent processing.
  • Improved Tool Specification Logic: Refactored the toToolSpecifications method to prioritize parametersJsonSchema for defining tool parameters, falling back to the existing parameters if parametersJsonSchema is not present.
  • Enhanced Test Coverage: Added comprehensive unit tests to validate the correct handling of MCP tools with parametersJsonSchema in both Map and Schema formats, ensuring robustness and reliability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for MCP tools with parametersJsonSchema in LangChain4j, which is a valuable enhancement. The implementation correctly prioritizes parametersJsonSchema and handles both Schema objects and other object types that need conversion. The accompanying tests are thorough and cover the new logic well. I have one suggestion to improve the efficiency of the schema conversion logic by using ObjectMapper.convertValue().

Comment on lines +439 to +441
ObjectMapper adkMapper = JsonBaseModel.getMapper();
String jsonSchemaStr = adkMapper.writeValueAsString(jsonSchemaObj);
schema = adkMapper.readValue(jsonSchemaStr, Schema.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For efficiency and conciseness, you can directly convert the jsonSchemaObj to a Schema object using ObjectMapper.convertValue(). This avoids the intermediate step of serializing to a JSON string and then deserializing back.

Suggested change
ObjectMapper adkMapper = JsonBaseModel.getMapper();
String jsonSchemaStr = adkMapper.writeValueAsString(jsonSchemaObj);
schema = adkMapper.readValue(jsonSchemaStr, Schema.class);
schema = JsonBaseModel.getMapper().convertValue(jsonSchemaObj, Schema.class);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant