-
Notifications
You must be signed in to change notification settings - Fork 270
feat: Enhance LangChain4j with MCP tool handling #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This update introduces the ability to handle MCP tools that utilize parametersJsonSchema for defining tool specifications. The implementation includes logic to convert JSON schema objects to Schema instances and updates the corresponding tests to ensure correct functionality.
Summary of ChangesHello @curefat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances LangChain4j's capabilities by integrating support for MCP tools that utilize Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for MCP tools with parametersJsonSchema in LangChain4j, which is a valuable enhancement. The implementation correctly prioritizes parametersJsonSchema and handles both Schema objects and other object types that need conversion. The accompanying tests are thorough and cover the new logic well. I have one suggestion to improve the efficiency of the schema conversion logic by using ObjectMapper.convertValue().
| ObjectMapper adkMapper = JsonBaseModel.getMapper(); | ||
| String jsonSchemaStr = adkMapper.writeValueAsString(jsonSchemaObj); | ||
| schema = adkMapper.readValue(jsonSchemaStr, Schema.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For efficiency and conciseness, you can directly convert the jsonSchemaObj to a Schema object using ObjectMapper.convertValue(). This avoids the intermediate step of serializing to a JSON string and then deserializing back.
| ObjectMapper adkMapper = JsonBaseModel.getMapper(); | |
| String jsonSchemaStr = adkMapper.writeValueAsString(jsonSchemaObj); | |
| schema = adkMapper.readValue(jsonSchemaStr, Schema.class); | |
| schema = JsonBaseModel.getMapper().convertValue(jsonSchemaObj, Schema.class); |
This update introduces support for MCP tools with parametersJsonSchema in LangChain4j, enhancing the tool specification handling. Additionally, code readability is improved by refactoring several sections for clarity and consistency.