Change page.goto to wait for DOM content to load #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where axe accessibility violations were being detected while pages were still loading, potentially resulting in incorrect violation reports. The change adds an explicit wait condition to the page navigation in the accessibility scanning function.
Key Changes:
- Modified
page.goto()to wait for DOM content to be loaded before proceeding with accessibility scanning
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Increased the timeout for page navigation to 20 seconds.
Log raw findings from AxeBuilder analysis for debugging.
Added logging for page content retrieval.
Author
|
based on this conversation, the issue was accessibility-bot permissions. Closing |
Author
|
temporarily reopening to test something. will close after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where axe violations are found while the page is still potentially loading (so the flagged violation is potentially incorrect)