still wip: convert seer preferences n+1 query to single query #107276
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
shruthilayaj
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| status=ObjectStatus.ACTIVE, | ||
| ).count() | ||
| if existing_repos_count != len(all_repos_to_check): | ||
| return Response({"detail": "Invalid repository"}, status=400) |
There was a problem hiding this comment.
Duplicate repos across projects cause false validation failure
High Severity
The validation logic compares existing_repos_count (unique matching database rows) against len(all_repos_to_check) (total input entries including duplicates). When the same repository is mapped to multiple projects, all_repos_to_check contains duplicate tuples, but the database count() only returns unique matches. This causes valid requests to incorrectly fail with "Invalid repository" when the same repo is shared across projects.
Additional Locations (1)
| provider = repo_data["provider"] | ||
| external_id = repo_data["external_id"] | ||
| owner = repo_data["owner"] | ||
| name = repo_data["name"] | ||
| all_repos_to_check.add((provider, external_id, f"{owner}/{name}")) |
There was a problem hiding this comment.
repo data serialized by
https://github.com/getsentry/sentry/blob/master/src/sentry/seer/endpoints/organization_autofix_automation_settings.py#L50-L54
where all these fields are required
| provider = repo_data["provider"] | ||
| external_id = repo_data["external_id"] | ||
| owner = repo_data["owner"] | ||
| name = repo_data["name"] |
There was a problem hiding this comment.
Serialized by this
https://github.com/getsentry/sentry/blob/master/src/sentry/seer/endpoints/project_seer_preferences.py#L36-L41
where all these fields are required
No description provided.