ref(scraps) use index imports #107265
Draft
ref(scraps) use index imports #107265
+5,581
−4,327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
natemoo-re
reviewed
Jan 30, 2026
| @@ -1,4 +1,5 @@ | |||
| import {Button, type ButtonProps} from 'sentry/components/core/button'; | |||
| import {Button, type ButtonProps} from '@sentry/scraps/button'; | |||
Member
There was a problem hiding this comment.
Hmm some of these use import type { ComponentProps } but some use import { Component, type ComponentProps }. While we're touching every file should we enforce one? import type is less of a foot-gun imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaps scraps imports to use the top level module exports. This change will allow us to enable module boundary rules and distinguish between scraps private modules and the public interface (we cannot do that currently as scraps is still to tightly coupled to sentry so this is the next best thing)
The PR generates lines due to scraps being sorted into separate import groups
ref DE-796