Skip to content

Conversation

@JPeer264
Copy link
Member

We already had this that #18987 was not closed because it was a PR to another branch (to make it easier for reviewing): #18987 (comment)

When having this a ticket will be opened, but not automatically closed on merge as this workflow is apparently not supported by GitHub if the base branch is not the default (I am not sure if it works for master, but if there is a PR to master then we should definitely open a ticket, even though it is not autoclosing - just because it might be a mistake that it was opened against master)

@JPeer264 JPeer264 requested review from Lms24 and logaretm January 30, 2026 09:48
@JPeer264 JPeer264 self-assigned this Jan 30, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

Codecov Results 📊


Generated by Codecov Action

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,978 - 9,182 -2%
GET With Sentry 1,714 19% 1,660 +3%
GET With Sentry (error only) 6,091 68% 6,000 +2%
POST Baseline 1,201 - 1,187 +1%
POST With Sentry 599 50% 588 +2%
POST With Sentry (error only) 1,073 89% 1,056 +2%
MYSQL Baseline 3,324 - 3,284 +1%
MYSQL With Sentry 482 15% 459 +5%
MYSQL With Sentry (error only) 2,745 83% 2,686 +2%

View base workflow run

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants