Skip to content

Conversation

@akronim26
Copy link

Fixes #189

@akronim26 akronim26 closed this Jan 27, 2026
@akronim26 akronim26 reopened this Jan 27, 2026
@BigLep BigLep added team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board. team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. labels Jan 28, 2026
@BigLep BigLep requested a review from Copilot January 28, 2026 19:18
@FilOzzy FilOzzy added this to FOC Jan 28, 2026
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Jan 28, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new terminate command to the data-set CLI that allows users to terminate a dataset and its associated payment rails. This addresses issue #189 which requested a convenient way to cleanup and stop paying utility for datasets.

Changes:

  • Added a new terminate subcommand to the data-set command that terminates both the dataset and its payment rails
  • Implemented ownership validation to ensure only the dataset owner can terminate
  • Added idempotent handling for already-terminated datasets
  • Enhanced piece display to show terminated datasets' pieces as "onchain orphaned"

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/commands/data-set.ts Adds the new terminate subcommand registration with argument parsing and error handling
src/data-set/run.ts Implements runTerminateDataSetCommand with owner validation, confirmation prompt, transaction submission, and result display
src/data-set/display.ts Updates renderPieces to mark pieces as ONCHAIN_ORPHANED when dataset's payment rail is terminated
src/test/unit/data-set.test.ts Adds comprehensive test coverage for successful termination, permission denial, and already-terminated scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add data-set $dataSetId --terminate

2 participants