-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Fix FieldsBelowInit: Reorder properties in DiffClampAnimatedNode #55361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdvacca
wants to merge
2
commits into
facebook:main
Choose a base branch
from
mdvacca:export-D91737148
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93bff69 to
27b329a
Compare
27b329a to
a294b34
Compare
cortinico
approved these changes
Jan 29, 2026
Contributor
cortinico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
a294b34 to
daceefc
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…ebook#55361) Summary: Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt. Moved `inputNodeValue` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91737148
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…ebook#55361) Summary: Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt. Moved `inputNodeValue` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91737148
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…ebook#55361) Summary: Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt. Moved `inputNodeValue` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91737148
…k#55360) Summary: Fixed FieldsBelowInit lint errors in ColorAnimatedNode.kt. Moved `color` and `context` computed properties above the init block to follow Kotlin initialization order conventions and prevent potential initialization issues. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91736974
…ebook#55361) Summary: Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt. Moved `inputNodeValue` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91737148
daceefc to
959d0e5
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…ebook#55361) Summary: Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt. Moved `inputNodeValue` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91737148
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…ebook#55361) Summary: Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt. Moved `inputNodeValue` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91737148
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…ebook#55361) Summary: Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt. Moved `inputNodeValue` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91737148
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…ebook#55361) Summary: Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt. Moved `inputNodeValue` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91737148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt.
Moved
inputNodeValuecomputed property above the init block to followKotlin initialization order conventions.
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D91737148