Fix FieldsBelowInit lint warning for nativeModules property #55352
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Facebook
mdvacca
force-pushed
the
export-D91709480
branch
from
ee6d59c to
392cfd4
Compare
mdvacca
force-pushed
the
export-D91709480
branch
from
392cfd4 to
6cc4a63
Compare
…#55352) Summary: Pull Request resolved: facebook#55352 **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
force-pushed
the
export-D91709480
branch
from
6cc4a63 to
a9d6818
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…#55352) Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91709480
|
This pull request has been merged in 5794141. |
Collaborator
|
This pull request was successfully merged by @mdvacca in 5794141 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Lint Issue: ANDROIDLINT FieldsBelowInit warning on line 347.
The
nativeModulesproperty was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution.Fix: Moved the
nativeModulescomputed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion.changelog: [internal] internal
Reviewed By: alanleedev
Differential Revision: D91709480