fix(anthropic): remove top_p parameter for Claude 4.5 models
#521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
thank you @muni-corn |
di-sukharev
requested changes
Oct 22, 2025
Author
|
hey @di-sukharev , have you had a chance to check this out again? 😁 |
|
@di-sukharev ping |
1 similar comment
|
@di-sukharev ping |
Contributor
|
@di-sukharev Would it be possible to merge this please? @muni-corn has made the requested changes and this issue forces us to either work on a fork or disable auto-updating since we can't use oco with anthropic's models without this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the
top_pparameter if the configured model string contains-4-5. this fixes #520 , where opencommit will fail because Anthropic does not support bothtemperatureandtop_pfor their 4.5 models.