-
Notifications
You must be signed in to change notification settings - Fork 14
fix: exclude custom-select from generic floating label trigger #5852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 83f3a8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
| &:has( | ||
| #{$selector}:focus-within, | ||
| #{$selector}:not(.db-custom-select-form-field):focus-within, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #{$selector}:not(.db-custom-select-form-field):focus-within, | |
| #{$focus-within-selector}:focus-within, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do it like this and this, the placeholder would be shown even if the focus is inside the dropdown. Which will show the "hint" of the placeholder while selecting a option
| @@ -161,7 +161,7 @@ $db-min-inline-size: var( | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $focus-within-selector: $selector; | |
| @if ($selector == summary) { | |
| $focus-within-selector: ""; | |
| } |
Proposed changes
resolves #4536
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-4536-flickering-floating-label