Skip to content

Conversation

@michaelmkraus
Copy link
Contributor

@michaelmkraus michaelmkraus commented Jan 21, 2026

Proposed changes

  • exclude custom-select from generic floating label trigger

resolves #4536

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-4536-flickering-floating-label

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

🦋 Changeset detected

Latest commit: 83f3a8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@db-ux/core-components Patch
@db-ux/ngx-core-components Patch
@db-ux/react-core-components Patch
@db-ux/wc-core-components Patch
@db-ux/v-core-components Patch
@db-ux/core-foundations Patch
@db-ux/core-stylelint Patch
@db-ux/core-migration Patch
@db-ux/agent-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michaelmkraus michaelmkraus moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Jan 21, 2026
@michaelmkraus michaelmkraus added 🐛bug Something isn't working 🎨(s)css Changes of components (s)css code labels Jan 21, 2026
@michaelmkraus michaelmkraus linked an issue Jan 21, 2026 that may be closed by this pull request
7 tasks
@michaelmkraus michaelmkraus removed their assignment Jan 21, 2026
@michaelmkraus michaelmkraus marked this pull request as ready for review January 21, 2026 14:07
@nmerget nmerget self-requested a review January 21, 2026 14:59
@nmerget nmerget moved this from 🎁 Ready for review to 👀 Actively In Review in UX Engineering Team Backlog Jan 21, 2026
@nmerget nmerget closed this Jan 21, 2026
@github-project-automation github-project-automation bot moved this from 👀 Actively In Review to ✅ Done in UX Engineering Team Backlog Jan 21, 2026
@nmerget nmerget reopened this Jan 21, 2026
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in UX Engineering Team Backlog Jan 21, 2026

&:has(
#{$selector}:focus-within,
#{$selector}:not(.db-custom-select-form-field):focus-within,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#{$selector}:not(.db-custom-select-form-field):focus-within,
#{$focus-within-selector}:focus-within,

Copy link
Collaborator

@nmerget nmerget Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do it like this and this, the placeholder would be shown even if the focus is inside the dropdown. Which will show the "hint" of the placeholder while selecting a option

@@ -161,7 +161,7 @@ $db-min-inline-size: var(
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$focus-within-selector: $selector;
@if ($selector == summary) {
$focus-within-selector: "";
}

@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🏘components 📕documentation Improvements or additions to documentation 🎨(s)css Changes of components (s)css code

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

Flickering floating label

3 participants