Skip to content

Conversation

@dimitri-yatsenko
Copy link
Member

Summary

Remove unit tests from pre-commit hooks.

Rationale

Pre-commit hooks should be fast. Running tests on every commit:

  1. Slows down development — Tests add significant time to each commit
  2. Blocks legitimate workflows — When creating a reproducer before implementing a fix, tests are expected to fail

Tests are better suited for CI workflows (GitHub Actions) where they:

  • Run in parallel with other checks
  • Don't block local development
  • Provide detailed reporting

Changes

  • Removed unit-tests hook from .pre-commit-config.yaml

Tests continue to run via GitHub Actions on push/PR.

Fixes #1356

🤖 Generated with Claude Code

Pre-commit hooks should be fast. Running tests on every commit:
- Slows down the development workflow
- Fails legitimately when creating reproducers before fixes

Tests are better suited for CI workflows where they run in parallel
and don't block local commits.

Fixes #1356

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions github-actions bot added bug Indicates an unexpected problem or unintended behavior enhancement Indicates new improvements labels Jan 30, 2026
@dimitri-yatsenko dimitri-yatsenko removed the bug Indicates an unexpected problem or unintended behavior label Jan 30, 2026
@dimitri-yatsenko dimitri-yatsenko merged commit c738cae into master Jan 30, 2026
4 checks passed
@dimitri-yatsenko dimitri-yatsenko deleted the fix/remove-tests-from-precommit branch January 30, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Indicates new improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests should not run on every commit

3 participants