Add IdentityHelper::getIdentity() #767
Open
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereuromark
approved these changes
Jan 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds a new getIdentity() method to the IdentityHelper class that returns the identity instance directly, allowing users to access the full identity object rather than just its data. It also improves the documentation for the existing get() method.
Changes:
- Added
getIdentity()method to return theIdentityInterfaceinstance - Enhanced documentation for the
get()method to clarify its behavior - Added a test case for the new
getIdentity()method
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/View/Helper/IdentityHelper.php | Adds the new getIdentity() method and improves docblock for get() method |
| tests/TestCase/View/Helper/IdentityHelperTest.php | Adds basic test coverage for the new getIdentity() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: ADmad <142658+ADmad@users.noreply.github.com>
Add test coverage for getIdentity() with no identity present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.