refactor: adapt visitor to new parser split method call contexts #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream parser (bytebase/parser#57) replaced the unified MethodCallContext with CollectionMethodCallContext and CursorMethodCallContext, and removed the GenericMethod catch-all. - Split visitMethodCall into visitCollectionMethodCall and visitCursorMethodCall - Update visitMethodChain to use CollectionMethodCall() and AllCursorMethodCall() instead of AllMethodCall() - Replace GenericMethod fallback with extractMethodNameFromText Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rebelice
approved these changes
Jan 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the MongoDB parser dependency and refactors the internal AST visitor to match the new method-call grammar split between collection and cursor method calls, while preserving existing translation behavior and error reporting.
Changes:
- Bump
github.com/bytebase/parserto a newer commit that introducesCollectionMethodCallContextandCursorMethodCallContext. - Refactor
visitMethodChainto handle a singleCollectionMethodCallfollowed by zero or moreCursorMethodCalls, instead of iterating a unifiedMethodCalllist. - Replace the old
visitMethodCall+extractMethodNamelogic withvisitCollectionMethodCall,visitCursorMethodCall, and a sharedextractMethodNameFromTexthelper for unsupported-method error handling.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/translator/visitor.go |
Adapts the visitor to the new parser method-call contexts, cleanly separates collection vs cursor handling, and centralizes unsupported-method name extraction using raw parse text. |
go.mod |
Updates the github.com/bytebase/parser dependency to a newer pseudo-version that exposes the new MongoDB grammar APIs. |
go.sum |
Syncs module checksums with the updated parser version to keep dependency resolution consistent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
github.com/bytebase/parserto pick up bytebase/parser#57 which replaces the unifiedMethodCallContextwith separateCollectionMethodCallContextandCursorMethodCallContextvisitMethodCallintovisitCollectionMethodCallandvisitCursorMethodCallto match the new grammar structureGenericMethodcatch-all withextractMethodNameFromTexthelper for unsupported method error messagesTest plan
go build ./...passesgo test -v ./...— all tests pass across all 3 packagesgolangci-lint run --allow-parallel-runners— 0 issues🤖 Generated with Claude Code