Skip to content

Conversation

@choejwoo
Copy link
Member

@choejwoo choejwoo commented Jan 28, 2026

Closes #26066

I reproduced the issue locally. I was able to reproduce the problem (see the attached screenshot).

스크린샷 2026-01-28 오후 8 07 43

The root cause was that deleting an old ReplicaSet from the grouped resources list could crash the UI with TypeError: Cannot read properties of undefined (reading 'info'), so I added a guard to avoid dereferencing a missing tree node and confirmed the crash no longer occurs.

After that, I also fixed a UX issue where the grouped resources panel kept a stale snapshot, causing deleted ReplicaSets to remain visible until the drawer was reopened, the panel now stores selected grouped IDs and derives the list from the latest tree/app state, and Delete triggers an immediate refresh via appChanged. As a result, the UI no longer crashes and the grouped list updates immediately after deletion (see the attached video).

2026-01-28.8.06.32.mov

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: choejwoo <jaewoo45@gmail.com>
@choejwoo choejwoo requested a review from a team as a code owner January 28, 2026 11:18
@bunnyshell
Copy link

bunnyshell bot commented Jan 28, 2026

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-tlob7x.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-tlob7x.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting one replicaset out of multiple ones, ui crash

2 participants