Skip to content

Conversation

@jwinters01
Copy link
Contributor

@jwinters01 jwinters01 commented Jan 26, 2026

closes #26153

  1. Updates EditablePanel to allow for subgroups of properties
  2. Extracts source properties to their own EditablePanel
  3. dynamically sets source properties based on Source Hydrator enablement

Result:

Exported.recording.mov

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
@bunnyshell
Copy link

bunnyshell bot commented Jan 26, 2026

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-ry4add.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-ry4add.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@jwinters01 jwinters01 marked this pull request as ready for review January 26, 2026 22:00
@jwinters01 jwinters01 requested a review from a team as a code owner January 26, 2026 22:00
@crenshaw-dev crenshaw-dev changed the title feat: support hydrator properties in summary tab feat(ui): support hydrator properties in summary tab Jan 26, 2026
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com>
Comment on lines +266 to +271
chart?: string;
helm?: ApplicationSourceHelm;
kustomize?: ApplicationSourceKustomize;
plugin?: ApplicationSourcePlugin;
directory?: ApplicationSourceDirectory;
ref?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
chart?: string;
helm?: ApplicationSourceHelm;
kustomize?: ApplicationSourceKustomize;
plugin?: ApplicationSourcePlugin;
directory?: ApplicationSourceDirectory;
ref?: string;
helm?: ApplicationSourceHelm;
kustomize?: ApplicationSourceKustomize;
plugin?: ApplicationSourcePlugin;
directory?: ApplicationSourceDirectory;

These fields aren't available in DrySource

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really? This was based on the Source Hydrator docs 😮 https://argo-cd.readthedocs.io/en/latest/user-guide/source-hydrator/#using-the-source-hydrator Should we update the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework Application Summary panel to incorporate Source Hydrator properties

2 participants