feat: add HTTPRoute to the network view (which also adds external url auto generate) (#17087) #26125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements that the
HTTPRouteofgateway.networking.k8s.io/v1is picked up in the network view of the ArgoCD UI and also adds auto generation of external links to the resource (so the clickable links in the UI, similar to what is done forIngress).Implementation details and open questions:
HTTPRoutefits generally into the implementation schema. The only downside is that we cannot determine wether its http or https, since that information is only present in the referencedGatewayresource. My assumption is that accessing another resource can / should not be done? I did not try it but I'm not sure how it would work with the permissions even. Also the referencedGatewaycould be in another namespace.So in the implementation I just assume https. A user could add another links using the general external-link annotation.
Gatewayis not added here since, at least to my understanding, it needs more refactoring or discussion. TheHTTPRoutereferences aGatewaywhich does not fit into theTargetRefs.TargetLabelsandLabelsis for the connection betweenServiceandPod.Checklist:
closes #17087 at least partially depending on the scope (
HTTPRouteis added,Gatewayis not)Screenshot:
