fix: cert-manager Certificate health check for Ready=False with Issuing message #26097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
ppapapetrou76
approved these changes
Jan 22, 2026
Contributor
ppapapetrou76
left a comment
ppapapetrou76
left a comment
There was a problem hiding this comment.
LGTM @timgriffiths but can you please sign-off your commits
…ng message This fixes a race condition where cert-manager sets Ready=False with a message containing 'Issuing' before the Issuing condition type is added. Previously, this would incorrectly show the certificate as Degraded instead of Progressing. The fix checks the Ready condition's message for 'Issuing' text when Ready=False, treating it as Progressing rather than Degraded. Signed-off-by: Tim Griffiths <griffiths.timothy@gmail.com> Signed-off-by: Timothy Griffiths <griffiths.timothy@gmail.com>
timgriffiths
force-pushed
the
fix/cert-manager-certificate-issuing-message
branch
from
bff5e98 to
438d91c
Compare
Contributor
Author
|
@ppapapetrou76 thank you for the review. Commit sign off fixed |
allanyung
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes cert-manager Certificate resources being incorrectly marked as "Degraded" during renewal/issuance when the Ready condition is False with an "Issuing" message, but before the separate Issuing condition type is added.
Problem
When a cert-manager Certificate is being issued or renewed, there's a race condition in the condition updates:
Ready=Falsewith a message containing "Issuing" (e.g., "Issuing certificate as Secret does not exist")type: IssuingconditionThe existing health check (added in commit 8886874) only looks for the
Issuingcondition type, missing this transitional state. This causes certificates to briefly show as "Degraded" in ArgoCD during normal renewal operations.Solution
This PR adds an additional check: when
Ready=False, also check if the message contains "Issuing". If so, return "Progressing" status instead of "Degraded".This aligns with the existing behavior that already returns "Progressing" when the Issuing condition type is present.
Changes
resource_customizations/cert-manager.io/Certificate/health.luato check for "Issuing" in the Ready condition messageprogressing_issuing_message_only.yamlto cover this scenarioChecklist