Skip to content

chore(appset): basic progressive sync e2e tests #26092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ranakan19 wants to merge 10 commits into
base: master
Choose a base branch
from
Open

chore(appset): basic progressive sync e2e tests #26092

ranakan19 wants to merge 10 commits into from
+1,024 −1

Conversation

@ranakan19
Copy link
Member

@ranakan19 ranakan19 commented Jan 21, 2026 •
edited
Loading

  • Adds an env var that applicationset controller expects to enable progressive sync to the test procfile
  • progressive sync test suite skipped if the env variable not set
  • pending tests for reverse deletionOrder

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

basic setup for progressive sync e2e tests
47981d7 
Signed-off-by: krana limaDocker <krana-lima-argo@example.com>
@bunnyshell
Copy link

bunnyshell bot commented Jan 21, 2026 •
edited
Loading

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

krana limaDocker and others added 2 commits January 21, 2026 16:41
@ranakan19
lint check
ec15429 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
fix expected ns and finalizers
d963ab6 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19 ranakan19 mentioned this pull request Jan 21, 2026
Open
@ranakan19
add expectation, fix flow for UI observation
485b6fd 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
use make target for progressive sync e2e tests run with env path var,…
0e9e514 
… lint

Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
run progressive sync e2e as part of existing e2e as beta
052fdbc 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
add test case for checking progression, rename expectation function, …
212128b 
…assisted by: claude-code

Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
Add more test cases
564e300 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
remove commented code
a4773ea 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19 ranakan19 changed the title basic setup for progressive sync e2e tests appset(chore): basic progressive sync e2e tests Jan 29, 2026
@ranakan19 ranakan19 changed the title appset(chore): basic progressive sync e2e tests chore (appset): basic progressive sync e2e tests Jan 29, 2026
@ranakan19 ranakan19 changed the title chore (appset): basic progressive sync e2e tests chore(appset): basic progressive sync e2e tests Jan 29, 2026
@ranakan19 ranakan19 marked this pull request as ready for review January 29, 2026 04:53
@ranakan19 ranakan19 requested review from a team as code owners January 29, 2026 04:53
rumstead
rumstead reviewed Jan 29, 2026
View reviewed changes
test/container/Procfile
helm-registry: sudo sh -c "OTEL_TRACES_EXPORTER=none REGISTRY_LOG_LEVEL=info registry serve /etc/docker/registry/config.yml"
dev-mounter: test "$ARGOCD_E2E_TEST" != "true" && go run hack/dev-mounter/main.go --configmap argocd-ssh-known-hosts-cm=${ARGOCD_SSH_DATA_PATH:-/tmp/argocd-local/ssh} --configmap argocd-tls-certs-cm=${ARGOCD_TLS_DATA_PATH:-/tmp/argocd-local/tls} --configmap argocd-gpg-keys-cm=${ARGOCD_GPG_DATA_PATH:-/tmp/argocd-local/gpg/source}
applicationset-controller: [ "$BIN_MODE" = 'true' ] && COMMAND=./dist/argocd || COMMAND='go run ./cmd/main.go' && sh -c "FORCE_LOG_COLORS=4 ARGOCD_FAKE_IN_CLUSTER=true ARGOCD_TLS_DATA_PATH=${ARGOCD_TLS_DATA_PATH:-/tmp/argocd-local/tls} ARGOCD_SSH_DATA_PATH=${ARGOCD_SSH_DATA_PATH:-/tmp/argocd-local/ssh} ARGOCD_BINARY_NAME=argocd-applicationset-controller $COMMAND --loglevel debug --metrics-addr localhost:12345 --probe-addr localhost:12346 --argocd-repo-server localhost:${ARGOCD_E2E_REPOSERVER_PORT:-8081}"
applicationset-controller: [ "$BIN_MODE" = 'true' ] && COMMAND=./dist/argocd || COMMAND='go run ./cmd/main.go' && sh -c "FORCE_LOG_COLORS=4 ARGOCD_FAKE_IN_CLUSTER=true ARGOCD_APPLICATIONSET_CONTROLLER_ENABLE_PROGRESSIVE_SYNCS=${ARGOCD_APPLICATIONSET_CONTROLLER_ENABLE_PROGRESSIVE_SYNCS:-false} ARGOCD_TLS_DATA_PATH=${ARGOCD_TLS_DATA_PATH:-/tmp/argocd-local/tls} ARGOCD_SSH_DATA_PATH=${ARGOCD_SSH_DATA_PATH:-/tmp/argocd-local/ssh} ARGOCD_BINARY_NAME=argocd-applicationset-controller $COMMAND --loglevel debug --metrics-addr localhost:12345 --probe-addr localhost:12346 --argocd-repo-server localhost:${ARGOCD_E2E_REPOSERVER_PORT:-8081}"
Copy link
Member

@rumstead rumstead Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we default ARGOCD_APPLICATIONSET_CONTROLLER_ENABLE_PROGRESSIVE_SYNCS to true and remove the override from the ci build?

rumstead
rumstead reviewed Jan 29, 2026
View reviewed changes
test/e2e/fixture/applicationsets/expectation.go
}

// This function checks that a step has expected app/apps (one step can have multiple apps)
func CheckApplicationInRightSteps(step string, expectedApps []string) Expectation {
Copy link
Member

@rumstead rumstead Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a mega nit: but if we are going to provide a function comment, may as well use go style.

Copy link
Member Author

@ranakan19 ranakan19 Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely agree, thanks for catching that, lemme fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rumstead rumstead rumstead left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ranakan19 @rumstead