fix: rectify transformRequestFunction precedence rules

[l2ysho]

The transformRequestFunction in enqueueLinks was being applied before pattern-based filtering (globs, regexps, pseudoUrls), which meant that request options set by patterns would overwrite changes made by transformRequestFunction. This was counterintuitive - users expected transformRequestFunction to have the final say over request modifications.

Solution

Reorder the processing pipeline so that transformRequestFunction is applied after all filtering and pattern matching:

Previous order: transformRequestFunction → Pattern filtering → Request creation
New order: Pattern filtering → Request creation → transformRequestFunction

Changes

packages/core/src/enqueue_links/enqueue_links.ts

• Moved transformRequestFunction execution to after createFilteredRequests()
• transformRequestFunction now operates on Request instances instead of RequestOptions
• Added handling for when transformRequestFunction returns a plain object (converts it to a Request instance)
• Updated JSDoc comments to clarify the correct precedence:
  • Lowest priority: Global label option
  • Medium priority: Pattern-specific options (globs, regexps, pseudoUrls)
  • Highest priority: transformRequestFunction

test/core/enqueue_links/enqueue_links.test.ts

• Added comprehensive test suite for label precedence rules covering:
  • Global label as lowest priority
  • Pattern labels overriding global labels
  • transformRequestFunction overriding pattern labels
  • transformRequestFunction modifying other request properties
  • Handling of plain objects returned from transformRequestFunction

closes #3070

[l2ysho]

another option is to pass transformRequestFunction to the createRequest function and do the job there, but then the logic is split to 2 places so I picked this way.

[B4nan]

This should target v4 branch

[l2ysho]

This should target v4 branch

I have to rebase then

[B4nan]

That might be a bit too much work, maybe better to recreate the PR (reset your changes, stash, hard reset to v4 upstream, unstash, resolve conflics once...)

[janbuchar]

It's worth trying to cherrypick those two commits 🤷

[l2ysho]

That might be a bit too much work, maybe better to recreate the PR (reset your changes, stash, hard reset to v4 upstream, unstash, resolve conflics once...)

It's worth trying to cherrypick those two commits 🤷

It was not so bad