fix: read and merge MCP config file paths instead of discarding them #870
+136
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when users provided `--mcp-config` with a file path in `claude_args`, the file path was silently discarded if inline JSON configs also existed (which the action always provides for its built-in servers). This meant user-provided MCP servers from file configs were never loaded. The fix reads file paths at parse time using `readFileSync` and merges their contents with inline JSON configs. Errors reading files (missing file, invalid JSON) are logged as warnings but don't fail the action. Fixes anthropics#754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mergeMcpConfigsfunction now reads file paths usingreadFileSyncand merges their contents with inline JSON configsTest plan
should read and merge mcp-config file path when no inline JSON existsshould merge file path config with inline JSON configs (fixes #754)- the exact scenario from the issueshould handle non-existent mcp-config file gracefullyshould handle invalid JSON in mcp-config file gracefullyshould merge multiple file paths