Skip to content

Conversation

@shivammathur
Copy link
Contributor

Description

Update PHP to 8.5 on Windows

Related issue: #13603

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

Copilot AI review requested due to automatic review settings January 29, 2026 06:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows toolset configuration to target PHP 8.5.

Changes:

  • Bump PHP from 8.4 to 8.5 in the Windows Server 2022 toolset.
  • Bump PHP from 8.4 to 8.5 in the Windows Server 2025 toolset.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
images/windows/toolsets/toolset-2022.json Updates the configured PHP major/minor version to 8.5 for Windows Server 2022 images.
images/windows/toolsets/toolset-2025.json Updates the configured PHP major/minor version to 8.5 for Windows Server 2025 images.

Comment on lines 313 to 315
"php": {
"version": "8.4"
"version": "8.5"
},
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toolset now targets PHP 8.5, but the published Windows image README files still list PHP 8.4.16 (e.g., images/windows/Windows2025-Readme.md:24 and Windows2022-Readme.md:23). Please update the Windows readmes/software report artifacts in the same PR (or clarify and link to where/when they will be regenerated) so the documented installed software matches the toolset configuration.

Copilot uses AI. Check for mistakes.
Comment on lines 345 to 347
"php": {
"version": "8.4"
"version": "8.5"
},
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toolset now targets PHP 8.5, but the published Windows image README files still list PHP 8.4.16 (e.g., images/windows/Windows2022-Readme.md:23 and Windows2025-Readme.md:24). Please update the Windows readmes/software report artifacts in the same PR (or clarify and link to where/when they will be regenerated) so the documented installed software matches the toolset configuration.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants