-
Notifications
You must be signed in to change notification settings - Fork 54
Remove experimental flag for case function
#320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae3f093 to
68add83
Compare
68add83 to
7ac83f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the experimental gating for the case() expression function so it is always available in expression completions, and cleans up related feature-flag plumbing and tests.
Changes:
- Removed the
allowCaseFunctionexperimental feature flag from@actions/expressionsfeature flags. - Updated expression completion APIs and the language service to no longer pass feature flags for completion filtering.
- Updated completion tests to expect
caseunconditionally and removed the “disabled” scenario.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| languageservice/src/complete.ts | Stops passing feature flags into expression completion; uses the simplified completion API. |
| languageservice/src/complete.test.ts | Updates completion tests to always include case; removes flag-specific setup and the “disabled” test. |
| languageservice/src/complete.expressions.test.ts | Removes FeatureFlags usage from expression completion tests while still asserting case is present. |
| expressions/src/features.ts | Removes allowCaseFunction from ExperimentalFeatures and from the known feature key list. |
| expressions/src/features.test.ts | Updates expectations for enabled feature lists after removing allowCaseFunction. |
| expressions/src/completion.ts | Removes feature-flag parameter and filtering from expression completion so case is always suggested. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
8d8f63f to
f99cd28
Compare
f99cd28 to
0410ab8
Compare
No description provided.