Skip to content

Conversation

@AllanGuigou
Copy link
Contributor

No description provided.

@AllanGuigou AllanGuigou force-pushed the allanguigou/default-case branch 2 times, most recently from ae3f093 to 68add83 Compare January 29, 2026 16:48
@AllanGuigou AllanGuigou force-pushed the allanguigou/default-case branch from 68add83 to 7ac83f4 Compare January 29, 2026 16:51
@AllanGuigou AllanGuigou marked this pull request as ready for review January 29, 2026 16:56
@AllanGuigou AllanGuigou requested a review from a team as a code owner January 29, 2026 16:56
Copilot AI review requested due to automatic review settings January 29, 2026 16:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the experimental gating for the case() expression function so it is always available in expression completions, and cleans up related feature-flag plumbing and tests.

Changes:

  • Removed the allowCaseFunction experimental feature flag from @actions/expressions feature flags.
  • Updated expression completion APIs and the language service to no longer pass feature flags for completion filtering.
  • Updated completion tests to expect case unconditionally and removed the “disabled” scenario.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
languageservice/src/complete.ts Stops passing feature flags into expression completion; uses the simplified completion API.
languageservice/src/complete.test.ts Updates completion tests to always include case; removes flag-specific setup and the “disabled” test.
languageservice/src/complete.expressions.test.ts Removes FeatureFlags usage from expression completion tests while still asserting case is present.
expressions/src/features.ts Removes allowCaseFunction from ExperimentalFeatures and from the known feature key list.
expressions/src/features.test.ts Updates expectations for enabled feature lists after removing allowCaseFunction.
expressions/src/completion.ts Removes feature-flag parameter and filtering from expression completion so case is always suggested.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@AllanGuigou AllanGuigou force-pushed the allanguigou/default-case branch from 8d8f63f to f99cd28 Compare January 29, 2026 17:24
@AllanGuigou AllanGuigou force-pushed the allanguigou/default-case branch from f99cd28 to 0410ab8 Compare January 29, 2026 17:24
@AllanGuigou AllanGuigou merged commit 191a7b6 into main Jan 29, 2026
7 checks passed
@AllanGuigou AllanGuigou deleted the allanguigou/default-case branch January 29, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants